InputCommon: Fix ControlGroup::SaveConfig with DefaultValue::Disabled #11606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
changed the title
I also changed LoadConfig, but that change doesn't affect correctness, it's only so it looks neat by matching SaveConfig. This bug was added in 18a4afb, the commit that introduced DefaultValue::Disabled. The bug can't actually be triggered in master, but it can be triggered in the Android input overhaul PR.
JosJuice
force-pushed
the
control-group-save-enabled
branch
from
4afc6e1
to
9b3816c
Compare
AdmiralCurtiss
approved these changes
Feb 26, 2023
This was referenced Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also changed LoadConfig, but that change doesn't affect correctness, it's only so it looks neat by matching SaveConfig.
This bug was added in PR #8729, the PR that introduced DefaultValue::Disabled. The bug can't actually be triggered in master, but it can be triggered in PR #11385.