Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SD card size option for converting folder -> file. #11609

Merged
merged 2 commits into from Jun 2, 2023

Conversation

AdmiralCurtiss
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss commented Feb 26, 2023

dolphin-sd-card-size

@iwubcode
Copy link
Contributor

Just curious, what is the advantage of specifying the card size?

@AdmiralCurtiss
Copy link
Contributor Author

AdmiralCurtiss commented Feb 26, 2023

Well... so you have a specific card size. Someone on Discord recently wanted an empty 2 GB SD card image to move files into using the Wii Menu's standard SD Card copy functionality for channels/saves, and that wasn't actually possible without manually creating enough files in the SD sync folder for the autodetection to create a size close to that. (and even then, you wouldn't have an easy way to get rid of those 'temporary' files in the SD image)

@iwubcode
Copy link
Contributor

iwubcode commented Feb 26, 2023

Just thinking this might be a bit confusing to users. Why wouldn't they want the biggest value if they have the space? What if they want to handle a size smaller than the min option..will they understand what 'auto' means? What happens if their data is larger than the size they select?

My question is, do we have a list of use cases where we'd need some specific value? Is the Wii Menu the only one? Maybe it'd be simpler to keep the automatic behavior and just enforce a minimum of 2GB so the Wii Menu would work? (or if there isn't enough disc space, then match exact but issue a panic alert telling them it won't work for the Wii Menu)

EDIT: or is it the Wii Menu that needs to be changed to support less than 2GB sizes? (that may cause emulation issues I guess?)

@AdmiralCurtiss
Copy link
Contributor Author

AdmiralCurtiss commented Feb 26, 2023

Okay, I seem to have confused you. The Wii Menu accepts any kind of size (well, probably up to some limit that I'm not aware of). They just wanted a large SD card image so they could put lots of channels/saves/DLC on there and use the Wii Menu as you would on, well, a real Wii.

@mbc07
Copy link
Contributor

mbc07 commented Feb 27, 2023

AFAICT real Wii officially supports SD and SDHC cards only, so 32 GiB is the theoretical limit. I would not be surprised with the existence of homebrew apps/games that can handle bigger cards, though...

Edit: I would probably drop 64 MiB from the list of options, it can barely hold anything and is below our historical minimum virtual SD Card size, which is 128 MiB...

@JosJuice
Copy link
Member

AFAICT real Wii officially supports SD and SDHC cards only, so 32 GiB is the theoretical limit.

You can make it bigger than 32 GiB no problem. It's just that if you buy an SD card that's bigger than 32 GiB, it's an SDXC card, meaning you have to reformat it from exFAT to FAT32 manually. Of course, Dolphin never uses exFAT, so for us this isn't a problem.

@iwubcode
Copy link
Contributor

Okay, I seem to have confused you. The Wii Menu accepts any kind of size (well, probably up to some limit that I'm not aware of). They just wanted a large SD card image so they could put lots of channels/saves/DLC on there and use the Wii Menu as you would on, well, a real Wii.

Yeah, apologies, I was very confused. I get it now :)

Source/Core/Core/Core.cpp Outdated Show resolved Hide resolved
@AdmiralCurtiss AdmiralCurtiss force-pushed the sd-size-select branch 3 times, most recently from a0ebfca to 6519c69 Compare March 5, 2023 18:23
@AdmiralCurtiss AdmiralCurtiss force-pushed the sd-size-select branch 2 times, most recently from 7f66cea to b29bb8e Compare April 9, 2023 19:50
@JMC47
Copy link
Contributor

JMC47 commented Jun 2, 2023

As someone who struggled with this exact scenario (installing a mod update onto a SD Card that was too small because Dolphin's auto-size didn't leave enough room) I absolutely want this.

@AdmiralCurtiss
Copy link
Contributor Author

I mean, I wrote this but it still looks fine to me too looking at it months later. So sure.

@AdmiralCurtiss AdmiralCurtiss merged commit ca484c7 into dolphin-emu:master Jun 2, 2023
14 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the sd-size-select branch June 2, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants