Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoCommon: move hirestexture data to reusable class called CustomTextureData #11612

Merged
merged 2 commits into from Mar 2, 2023
Merged

VideoCommon: move hirestexture data to reusable class called CustomTextureData #11612

merged 2 commits into from Mar 2, 2023

Conversation

iwubcode
Copy link
Contributor

@iwubcode iwubcode commented Mar 1, 2023

Split out from #11300 and replaced existing VideoCommon code with CustomTextureData

@AdmiralCurtiss
Copy link
Contributor

Most of the functions in CustomTextureData.cpp also look like they could be static.

AdmiralCurtiss
AdmiralCurtiss approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Untested.

@lioncash lioncash merged commit cbbc518 into dolphin-emu:master Mar 2, 2023
14 checks passed
@iwubcode iwubcode deleted the custom_texture_data branch March 2, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

@AdmiralCurtiss AdmiralCurtiss AdmiralCurtiss approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@iwubcode @AdmiralCurtiss @lioncash