DolphinQt: Rework TAS input threading #11622
Merged
+276
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR isn't quite finished yet – the new approach is fully implemented for buttons, but hasn't been implemented for analog controls. I've opened the PR early to get feedback on whether my threading model is a good approach. |
|
The threading model seems fine to me. On master, holding a controller button and unchecking the box in the TAS window will result in the controller input and checkbox staying pressed. In this PR, the checkbox (and actual input sent to the game) will become unpressed. Is that change intentional? |
|
Yes, though the main reason I did it was so it would be consistent with how analog inputs worked so I could simplify the code. |
JosJuice
force-pushed
the
tas-input-nonblocking
branch
from
9ab6c5f
to
7bf3d59
Compare
|
Alright, this should be ready to go now. |
This gets rid of a blocking operation, improving performance and fixing https://bugs.dolphin-emu.org/issues/12893. This also makes us no longer directly access the state of certain UI elements from the CPU thread, which probably wasn't thread-safe but doesn't seem to have caused any observable issues so far.
IIRC we needed this before the input override system was added.
JosJuice
force-pushed
the
tas-input-nonblocking
branch
from
7bf3d59
to
0300b44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This gets rid of a blocking operation, improving performance and fixing https://bugs.dolphin-emu.org/issues/12893.
This also makes us no longer directly access the state of certain UI elements from the CPU thread, which probably wasn't thread-safe but doesn't seem to have caused any observable issues so far.
This is an alternative to PR #11620.