Fix KillRenderer config changed regression #11625
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phire
force-pushed
the
eventhook_nodiscard
branch
from
24ad410
to
901f12c
Compare
|
Tested on Windows. With this PR, V-Sync is once again properly disabled when fast forwarding on OpenGL and Vulkan. |
AdmiralCurtiss
approved these changes
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The callback handle was being discarded, resulting in the callback immediately unregistering.
Should fix issues with vsync not disabling during fast-forwarding, along with a bunch of other regressions that probally haven't been reported.
I also added
[[nodiscard]]toHookableEvent::Registerso we will get some warning about such mistakes in the future.