HW/DVD: Refactor DVDInterface and DVDThread to classes.

[AdmiralCurtiss]

No description provided.

[JosJuice]

Can't we name the class DVDInterface instead of DVDInterfaceManager? Manager doesn't really add anything to the name.

[JosJuice]

A side note: When I created DVDThread, I designed it as something that only DVDInterface should have to deal with accessing. So it would be nice to make DVDThread a private member of the DVDInterface class instead of making it accessible through the System class... But DI.cpp is currently violating this model, so let's keep this outside the scope of the PR.

[AdmiralCurtiss]

Can't we name the class DVDInterface instead of DVDInterfaceManager? Manager doesn't really add anything to the name.

The reason I added Manager for all of these is that I figured having a class be the same name as its enclosing namespace could get both confusing and annoying -- eg. if you want to access DVDInterface::DriveState (that is, namespace::enum) from within the DVDInterface::DVDInterface (that is, namespace::class) you can't just use DVDInterface::DriveState but have to use ::DVDInterface::DriveState. I do agree that Manager doesn't add much but I think it's better to have a different name than the namespace here.

A side note: When I created DVDThread, I designed it as something that only DVDInterface should have to deal with accessing. So it would be nice to make DVDThread a member of the DVDInterface class instead of the System class... But DI.cpp is currently violating this model, so let's keep this outside the scope of the PR.

Yeah I was wondering about that. That does make sense to change later.

[JosJuice]

Right, I hadn't thought about the namespace. What would you think about changing the namespace to e.g. DVD?

[AdmiralCurtiss]

Sure, I guess we can do it that way.

[JosJuice]

Can we do the same for DVDThread? (This will mean it now shares a namespace with DVDInterface, which I think is fine. When they're in separate classes, we no longer need to use the namespace to keep them apart.)