Skylander Portal: Play Trap Team Audio #11644
Merged
+40
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
reviewed
Mar 12, 2023
deReeperJosh
force-pushed
the
trapteamaudio
branch
2 times, most recently
from
17381ed
to
7c8b4ab
Compare
deReeperJosh
force-pushed
the
trapteamaudio
branch
from
d0ec265
to
dc8d61b
Compare
AdmiralCurtiss
approved these changes
Mar 12, 2023
Asserts and length handling
|
Will leave this here as well: The Gulper Probably a better example of how the audio works, you can hear the Villian 'trapped' in the portal, which would normally only play via the Portal Speaker |
deReeperJosh
force-pushed
the
trapteamaudio
branch
from
dc8d61b
to
f27e821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR introduces the ability to play the audio that would normally play through the Trap Team portal speaker via Dolphin.
The Trap Team speaker is 1 channel, so code has been replicated from the Wiimote speaker to duplicate each sample, and play it as stereo audio. The audio data is 16 bit unsigned pcm @ 8khz sample rate.
Here's a video of it working, where the audio you hear from the portal is while the villain is being trapped.