Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix starting movie recording with existing Wii save #11665

Merged
merged 2 commits into from Mar 19, 2023

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Mar 16, 2023

A change made in 0d095b4 didn't take into account that the movie system doesn't set sync_titles.

A change made in 0d095b4 didn't take into account that the movie system
doesn't set sync_titles.
@AdmiralCurtiss
Copy link
Contributor

I'd rather just set the sync_titles for TAS bootup, all these special cases in the code make it really hard to follow for any given case... but yeah I guess this is fine. We should refactor the entire TAS flow anyway.

@AdmiralCurtiss AdmiralCurtiss merged commit a4d3342 into dolphin-emu:master Mar 19, 2023
14 checks passed
@JosJuice JosJuice deleted the fix-movie-wii-save branch March 19, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants