CMake: Use generator expressions for codesign targets #11667
Merged
+11
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TellowKrinkle
force-pushed
the
DontSucceedOnLinkFail
branch
from
173a5b9
to
3f7b00a
Compare
Also works around a bug where CMake's ninja generator doesn't properly handle ||'s on POST_BUILD commands, making the || apply to the whole build like `<link> && custom0 || custom1`
TellowKrinkle
force-pushed
the
DontSucceedOnLinkFail
branch
from
3f7b00a
to
d037c60
Compare
|
I'm not very familiar with Mac stuff but in terms of CMake this makes sense to me. |
OatmealDome
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Switches codesign targets from blindly attempting to codesign the places where targets might be placed to using generator expressions so cmake inserts the actual location of the target.
Also changes storyboard compiling from a
POST_BUILDstep to using proper dependency tracking. In addition to avoiding the above issue, this also means that if someone edits the.storyboard, it will properly be recompiled.