Deglobalize Interpreter #11671
Merged
Deglobalize Interpreter #11671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
deglobal-interpreter
branch
from
c77fb03
to
454d2fd
Compare
iwubcode
reviewed
Mar 19, 2023
JosJuice
approved these changes
Mar 19, 2023
lioncash
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Design notes: The static instruction functions remain static because the JIT (cached interpreter) calls into them, and getting pointers to member functions to call is apparently impossible in C++? Doesn't make much difference though, every one of them just gets a reference to the running Interpreter instance instead.
That aside, this is surprisingly straightforward, just a lot of
PowerPC::ppcState->m_ppc_state...