New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertex Loader Microoptimization #11673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
reviewed
Mar 19, 2023
3bc3fb7
to
392eb11
Compare
|
From https://dolphin.ci/#/builders/30/builds/1388/steps/8/logs/stdio: |
…manager if necessary.
ebaa504
to
747974c
Compare
lioncash
reviewed
Mar 20, 2023
Before, both of those were calculated 3 times due to the ASSERTs.
747974c
to
93fce0e
Compare
|
I fixed that assert the CI ran into as well as the other review comments. The PR should be ready for another review. |
degasus
reviewed
Mar 29, 2023
TellowKrinkle
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Just a couple of tiny things that showed up in the profiler in ended up making a measurable difference.
My test case is the Mario Galaxy comet observatory after loading a save game.
Dual core disabled, CPU EFB access disabled, Zen 3 5900X
Before: 118 FPS
After: 128 FPS
Mario Galaxy is particularly heavy when it comes to primitives, so this probably doesn't make a difference in most other games.