Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertex Loader Microoptimization #11673

Merged
merged 3 commits into from Mar 30, 2023

Conversation

K0bin
Copy link
Contributor

@K0bin K0bin commented Mar 19, 2023

Just a couple of tiny things that showed up in the profiler in ended up making a measurable difference.

My test case is the Mario Galaxy comet observatory after loading a save game.
Dual core disabled, CPU EFB access disabled, Zen 3 5900X
Before: 118 FPS
After: 128 FPS

Mario Galaxy is particularly heavy when it comes to primitives, so this probably doesn't make a difference in most other games.

@K0bin K0bin force-pushed the vertex-loader-micro-opt branch 2 times, most recently from 3bc3fb7 to 392eb11 Compare March 19, 2023 23:15
@Pokechu22
Copy link
Contributor

From https://dolphin.ci/#/builders/30/builds/1388/steps/8/logs/stdio:

Dolphin>>> 25:53:355 Core/Boot/Boot.cpp:623 N[BOOT]: Booting DFF: /Users/administrator/dff/ssbm-pointsize_1.dff
Dolphin>>> 25:53:437 VideoCommon/VertexManagerBase.cpp:191 E[Video]: Warning: An error occurred.
Dolphin>>> 
Dolphin>>> VertexManager: Too few remaining index values (9 > 8). 32-bit indices or primitive breaking needed.
Dolphin>>> 
Dolphin>>>   Condition: count <= remaining_index_generator_indices
Dolphin>>>   File: /Users/administrator/buildbot-worker/osx_m1/pr-fifoci-mvk-osx-m1/build/Source/Core/VideoCommon/VertexManagerBase.cpp
Dolphin>>>   Line: 191
Dolphin>>>   Function: PrepareForAdditionalData
Dolphin>>> 
Dolphin>>> Ignore and continue?
Dolphin>>> Dolphin [refs/pull/11673/head] 5.0-19058 | JITARM64 SC | Vulkan | HLE
FIFO log playback failed for /Users/administrator/dff/ssbm-pointsize_1.dff

@K0bin K0bin force-pushed the vertex-loader-micro-opt branch 2 times, most recently from ebaa504 to 747974c Compare March 20, 2023 00:00
@K0bin
Copy link
Contributor Author

K0bin commented Mar 29, 2023

I fixed that assert the CI ran into as well as the other review comments.

The PR should be ready for another review.

@degasus degasus merged commit 50a45bd into dolphin-emu:master Mar 30, 2023
14 checks passed
@K0bin K0bin deleted the vertex-loader-micro-opt branch March 30, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants