Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GameSettings] Change remaining 0/1 bools to False/True #11674

Merged
merged 1 commit into from Mar 20, 2023

Conversation

bslenul
Copy link
Contributor

@bslenul bslenul commented Mar 20, 2023

Very minor PR to make game settings more consistent for some bools (MMU, CPUThread and LowDCBZHack), replacing 0/1 with False/True.

While searching for 0/1 bools I found 2 unused variables, UseDualCore and Patch Region, so:

Changed UseDualCore = 0 to CPUThread = False in GDV.ini (not even sure if it's needed? Couldn't find any info on the initial commit, on the wiki or the forums, tried a single race and it seemed fine with and without Dual Core, so idk...).

And removed the Patch Region line from GNWE69.ini, while I was at it I moved ImmediateXFBEnable = False from that same file to a new GNW.ini (unless there's a good reason this is only applied to the USA version?).

Hope this is fine!

@delroth delroth merged commit 744e14b into dolphin-emu:master Mar 20, 2023
14 checks passed
@bslenul bslenul deleted the gamesettings-bool-cleanup branch March 20, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants