Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Make button in the settings open user folder #11689

Merged
merged 2 commits into from Mar 29, 2023
Merged

Android: Make button in the settings open user folder #11689

merged 2 commits into from Mar 29, 2023

Conversation

K0bin
Copy link
Contributor

@K0bin K0bin commented Mar 24, 2023 •
edited

Now that we have the DocumentsProvider, we can change the file manager button in the settings to directly open that.

cc @t895 @MayImilae

Screenshot_2023-03-24-16-40-02-29_c72eb4c8f207d9338cfe2ba1429ddbde.jpg

t895
t895 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@t895 t895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Source/Android/app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@MayImilae
Copy link
Contributor

Design LGTM.

@K0bin
Copy link
Contributor Author

K0bin commented Mar 26, 2023

Addressed feedback.

@t895 t895 merged commit 15be899 into dolphin-emu:master Mar 29, 2023
14 checks passed
@K0bin K0bin deleted the android-open-user-folder branch May 1, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosJuice JosJuice JosJuice left review comments

@t895 t895 t895 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@K0bin @MayImilae @JosJuice @t895