JitInterface: Refactor to class, move to System. #11696
Merged
+247
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Mar 26, 2023
AdmiralCurtiss
force-pushed
the
jit-interface-class
branch
from
6bce2c7
to
7f50c07
Compare
JosJuice
approved these changes
Mar 26, 2023
lioncash
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
InvalidateICacheLineFromJIT()has a weird signature so we don't have to rewrite the JIT function that calls it, but I think that's fine for now -- I might do a follow-up PR on that one, since the Jit64 should really useABI_CallFunctionPRR()instead of the manual stuff it's doing... Otherwise pretty straightforward.