Remove GCI Folder Path from the Wrote to OSD Message #11697
Conversation
|
"GCI Folder" seems very technical for something that we put in user-facing OSDs. Why not always say "memory card A/B" regardless of the backend storage implementation? |
|
Also note that this will still leak full path when the write fails. |
I went with that because that is the name for it in Dolphin's settings. If we're going to change what GCI Folder is called, we should probably do it everywhere all at once. We've talked about it once before and everyone involved in the conversation was pretty happy with changing GCI Folder to "Memory Card Folder" and Memory Card to "Memory Card File". That's for another day though.
Yea I know. This is just covering the primary case. For the write failures, something more nuanced will be required, such as shortening the string ala what I did in #11485. Unlike with the wrote messages, the errors actually have a reason to have the file path along with the file name - to help the user go to the file in question and diagnose the problem. So to best take care of that issue, ideally we'd have a shortened path starting with the user folder that would then go to the file name, for example: |
Follow up to PR11470. Forgot to do GCI as well. Oops.
This is a follow up to #11470. In that one I only did Memory Cards, and forgot to do the GCI Folder as well. Whoops.
This removes the GCI Folder path from the wrote to OSD message, to make it less likely that streamers will get dox'd from Dolphin. That is all.
Before:
After:
