Shaders: Add error message for asciiart shader if shader_subgroup is missing. #11703
+148
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With no modification.
…missing. This extension is currently required to get good performance. So instead of maybe triggering a GPU hang, let's just disable the shader and show a warning instead. Sadly our postprocessing framework does not support reporting a warning, so the way to display the warning is a bit hacky. But this is an ascii-art shader, we already have a font in the shader, so let's use it.
iwubcode
approved these changes
Mar 29, 2023
lioncash
approved these changes
Mar 30, 2023
mbc07
reviewed
Mar 30, 2023
| #endif | ||
| } | ||
|
|
||
| // "Error: The AsciiArt shader requires the missing GPU extention KHR_shader_subgroup." |
There was a problem hiding this comment.
Did you mean "extension" instead? "Extention" sounds like a typo...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This extension is currently required to get good performance.
So instead of maybe triggering a GPU hang, let's just disable the shader and show a warning instead.
Sadly our postprocessing framework does not support reporting a warning, so the way to display the warning is a bit hacky.
But this is an ascii-art shader, we already have a font in the shader, so let's use it.