Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netplay: More logging before game start. #11704

Merged
merged 2 commits into from Mar 30, 2023
Merged

Netplay: More logging before game start. #11704

merged 2 commits into from Mar 30, 2023

Conversation

AdmiralCurtiss
Copy link
Contributor

We've gotten repeated support requests for netplay failing to start with Wii saves, log more so I can maybe figure out why.

iwubcode
iwubcode approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could possibly change enum classes like SyncCodeID to have a fmt formatter that would print the string in addition to numeric value. But this is probably helpful enough as is. LGTM

@delroth delroth merged commit 7e9a63b into dolphin-emu:master Mar 30, 2023
13 of 14 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the more-log branch March 30, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwubcode iwubcode iwubcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@AdmiralCurtiss @iwubcode @delroth