Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SoundTouch to 2.3.2 commit 1eda9c0b01039f29d230a46cda9f2290bbd1f62b #11706

Merged
merged 2 commits into from Apr 2, 2023

Conversation

Minty-Meeo
Copy link
Member

This update includes every Dolphin-specific modification I could find in the commit history. Hopefully no issues arise from this update. This PR superscedes #10671. I'm making it because I upstreamed some warning fixes to SoundTouch itself. According to #10671, this also patches some CVEs, which is a plus.

@AdmiralCurtiss
Copy link
Contributor

AdmiralCurtiss commented Mar 31, 2023

Can you split out the Dolphin-specific modifications into an extra commit?

(That is, make this two commits: One commit to update to the unmodified 2.3.2, then one commit to apply the Dolphin-specific modifications on top.)

@Minty-Meeo
Copy link
Member Author

Certainly, that would make it clearer.

@Minty-Meeo
Copy link
Member Author

Minty-Meeo commented Apr 1, 2023

Problematic typedefs were moved into the soundtouch namespace with 16c9032.
SAMPLETYPE was changed from floats to shorts, and x86 optimizations were disabled with 8ff26a6.
Nonexact SIMD optimizations were enabled with d8f5ecf.
The "soundtouch_config.h" include started being commented out with 91fe5cc.
Exception handling I think has always been disabled.
If I recall, I put the change in BPMDetect.cpp to remove the non-standard _USE_MATH_DEFINES define.

I want to mention that most of these seem to be more easily configurable using either the soundtouch_configure.h header or defining things from the command line. I am bad at CMake, though, so I couldn't figure out the latter and left it as it was.

Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested on Windows.

@AdmiralCurtiss AdmiralCurtiss merged commit 0cd70c2 into dolphin-emu:master Apr 2, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants