IOS/FS: More accurate emulation of GetDirectoryStats() and GetNandStats(). #11711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
ios-fs-stats
branch
from
beae2ed
to
4d5e8e7
Compare
iwubcode
approved these changes
Apr 1, 2023
AdmiralCurtiss
force-pushed
the
ios-fs-stats
branch
from
4d5e8e7
to
c5664dc
Compare
|
Any more comments here? Otherwise I'll merge this in the next few days so I can implement https://bugs.dolphin-emu.org/issues/13225 |
AdmiralCurtiss
force-pushed
the
ios-fs-stats
branch
from
c5664dc
to
8473b11
Compare
…is not a directory.
…) and GetDirectoryStats().
AdmiralCurtiss
force-pushed
the
ios-fs-stats
branch
from
8473b11
to
5373fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The stats should actually match console now, which means block sizes for saves, channels and free blocks according to the Wii Menu should now match console too.
I've tested this by taking a NAND dump, importing that in Dolphin into an empty Wii folder, and then running this self-written homebrew (binary) and comparing the output.
console-stats.txt
dolphin-stats-before.txt
dolphin-stats-after.txt
The log output of my homebrew to test this is still noticeably different because we don't seem to correctly implement permissions for ReadDirectory() -- or maybe that's because I'm launching the homebrew directly on Dolphin instead of through the Homebrew Channel? File order also doesn't seem to be preserved when importing a NAND dump.
For reference:
Console:
Imported NAND:
Dolphin before:
Dolphin after:
