Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS/Network/KD: Reload DLList on call to DownloadNowEx #11722

Merged
merged 1 commit into from Apr 11, 2023

Conversation

noahpistilli
Copy link
Member

WiiConnect24 Channels will correct their entry in the DLList if needed before their call to DownloadNowEx.

Since we load the DLList on IOS reload, these changes are not reflected until next IOS reload.

@delroth delroth requested a review from leoetlino April 4, 2023 19:59
@AdmiralCurtiss
Copy link
Contributor

Wouldn't it be enough to just call m_dl_list.ReadDlList() instead of constructing a new object?

@noahpistilli
Copy link
Member Author

It would be, not sure why I did that.

Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. @leoetlino Do you want to review this too?

Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a sane thing to do

@leoetlino leoetlino merged commit e225ca8 into dolphin-emu:master Apr 11, 2023
14 checks passed
@JMC47
Copy link
Contributor

JMC47 commented Apr 11, 2023

Does this fix any user-facing issues? Asking for if I need to put it in the Progress Report.

@noahpistilli
Copy link
Member Author

Does this fix any user-facing issues? Asking for if I need to put it in the Progress Report.

It does, on first boot of a WiiConnect24 channel a user is faced with error 109999. This fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants