GMPE01, GP5E01, GP6E01, GP7E01, RM8E01: Code Updates #11734
Merged
+494
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please explain what these updates are for. |
|
This pr addresses code changes made in the mario party netplay community.. codes were made to improve gameplay. |
|
I wasn't able to test all of the cheat codes, but they seem to be properly added and credited. |
Rumi-Larry
reviewed
Apr 11, 2023
There was a problem hiding this comment.
A bunch of names for cheats have abnormal grammar, that needs checking by a native English speaker.
Also, I recommend that all instances of "Last 5 Turns" be between parentheses and with the word "events" appended e.g. ["Last 5 Turns" events happen....]. Otherwise it's very confusing to read.
|
any chance for a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.