IOS/Network/KD: Implement GetSchedulerStat #11736
Conversation
| std::lock_guard lg(m_scheduler_buffer_lock); | ||
|
|
||
| m_scheduler_buffer[32 + m_error_count] = Common::swap32(new_code); | ||
| m_error_count++; |
There was a problem hiding this comment.
This never seems to be reset, so this might go out of bounds over time I think?
There was a problem hiding this comment.
That is true, best practice should be to check if it will go out of bounds. However, no official title will call KD Download enough, let alone resume after an error to cause a bounds error.
There was a problem hiding this comment.
Looking at actual behaviour, it will reset the index back to 0 once there are 32 errors, but keep the error count.
noahpistilli
force-pushed
the
get-scheduler-stat
branch
from
38a9ff2
to
2fff1a5
Compare
|
|
||
| std::lock_guard lg(m_scheduler_buffer_lock); | ||
|
|
||
| m_scheduler_buffer[32 + (m_error_count & 0x1f)] = Common::swap32(new_code); |
There was a problem hiding this comment.
| m_scheduler_buffer[32 + (m_error_count & 0x1f)] = Common::swap32(new_code); | |
| m_scheduler_buffer[32 + (m_error_count % 32] = Common::swap32(new_code); |
IMO that's a clearer way to express the intended behaviour ("reset the index back to 0 once there are 32 errors but keep the error count").
| @@ -52,11 +51,24 @@ class NetKDRequestDevice : public Device | |||
| return std::nullopt; | |||
| } | |||
|
|
|||
| enum class ErrorType | |||
| { | |||
| ACCOUNT, | |||
There was a problem hiding this comment.
We don't use SCREAMING_CASE for enum class values (because unlike C-style enumerators they do not leak into the surrounding scope, so there is less of a need for them to stand out)
noahpistilli
force-pushed
the
get-scheduler-stat
branch
from
76aefa2
to
467b961
Compare
Implements the GetSchedulerStat Ioctl which is required for proper rendering of errors in WiiConnect24 Channels.
Currently if an error arises, the only way to know what went wrong is to look at logs. Even then, it doesn't give an HTTP status code if the server errored.
Before
After
