Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerPC: Refactor to class, move to System. #11741

Merged
merged 1 commit into from Apr 10, 2023
Merged

PowerPC: Refactor to class, move to System. #11741

merged 1 commit into from Apr 10, 2023

Conversation

AdmiralCurtiss
Copy link
Contributor

No description provided.

@AdmiralCurtiss AdmiralCurtiss force-pushed the ppc-class branch 2 times, most recently from 5b271ea to a9a8bf9 Compare April 8, 2023 13:29
JosJuice
JosJuice reviewed Apr 8, 2023
View reviewed changes
Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from a few nits.

Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/WatchWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/WatchWidget.cpp Outdated Show resolved Hide resolved
@JosJuice JosJuice merged commit 4c80c99 into dolphin-emu:master Apr 10, 2023
14 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the ppc-class branch April 10, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosJuice JosJuice JosJuice left review comments

@lioncash lioncash lioncash approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@AdmiralCurtiss @lioncash @JosJuice