IOS/DI: Remove RegisterWrapper. #11744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
approved these changes
Apr 9, 2023
There was a problem hiding this comment.
Looks good to me. Theoretically something could be done to preserve RegisterWrapper (e.g. storing them as variables in the device instance and constructing them with a reference to mmio), but this is the only IOS module that we implement like this (I don't think any of the other ones would be practical to implement like this either), so it's probably not worth the effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There's no good way to use this with non-global state, and it's only used in a few places, so let's just get rid of it.