Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BCn texture support on iOS where available #11757

Merged
merged 2 commits into from Apr 29, 2023

Conversation

TellowKrinkle
Copy link
Contributor

So all those M1 iPads can enjoy their high res texture packs

Note: This means Xcode 14.3 will be required for anyone compiling for iOS. Should I add anything to cmake for that?

Copy link
Member

@OatmealDome OatmealDome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: Xcode requirement

I think it would be a good idea even for upstream, since we do technically have one but we don't explicitly state what it is anywhere (I don't even know what it is either). We give an error when Visual Studio is outdated, so why not do the same for Xcode?

Externals/mbedtls/CMakeLists.txt Outdated Show resolved Hide resolved
@TellowKrinkle
Copy link
Contributor Author

Okay, I stuck in the minimum Xcode version (which appears to be 13.0 for targeting macOS)

I also updated the minimum GCC to 10, as we now use consteval which requires 10. Haven't actually tested 10, so the minimum could be higher though.

@OatmealDome
Copy link
Member

Hmm, I didn't expect compiler version checks for some reason, but it makes perfect sense. We have #10969 for this already, which is more complete (covers more compilers), but I have no idea about its status.

Could you drop the Xcode and GCC commits from this PR? I'll merge it right after, and then we can figure out what's going on with the compiler version stuff. Sorry about the hassle.

@OatmealDome OatmealDome merged commit 28f1a4c into dolphin-emu:master Apr 29, 2023
14 checks passed
@TellowKrinkle TellowKrinkle deleted the BCniOS branch April 30, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants