VideoBackends:Metal: Fix perf queries #11759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where perf queries could end up including counts from previous queries
TellowKrinkle
force-pushed
the
MTLPerfQueryFixes
branch
from
4c81f35
to
09c8051
Compare
OatmealDome
approved these changes
Apr 18, 2023
|
Confirmed fixed: https://twitter.com/sup39x1207/status/1647042422097207297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In #11647, the user was also kind enough to give the first ever test of the Metal renderer's PerfQuery implementation and it was pretty broken: https://twitter.com/sup39x1207/status/1635115984108548096
Hopefully it's now less broken, but I still don't know how to get that test screen to verify