Fix PPCCache savestate behavior #11765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minty-Meeo
force-pushed
the
ppc-cache-savestate
branch
3 times, most recently
from
0915396
to
e372caf
Compare
|
Even though this does not change the savestate format, should this still increment STATE_VERSION to make it clear that these files are semi-incompatible with prior versions? Or are we not that worried about it? |
PR dolphin-emu#11183 regressed the lookup table reconstruction and, for some reason, added an else clause that clobbered the dCache whenever dCache emulation is turned on.
Minty-Meeo
force-pushed
the
ppc-cache-savestate
branch
from
e372caf
to
0948f0e
Compare
|
@mkwcat I want to ask. What was the else clause this PR removes meant to do? It seems like a mistake, as removing it makes everything work fine. |
|
Yeah, it was a mistake |
lioncash
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR #11183 regressed the lookup table reconstruction and, for some reason, added an else clause that clobbered the dCache whenever dCache emulation is turned on.