DolphinQt: fix some usability issues #11774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuffle2
changed the title
Pokechu22
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Can confirm that the second commit is good. The separate handling in Windows was added in #9104, though there were further changes in #10500 which made it so that argc and argv exist. I confirmed that filenames with accents still work properly.
I don't use DPI changing personally so I haven't tested the first commit. It's probably correct though.
Qt already does this itself programmatically. Setting in the manifest interferes with Qt's internal handling of dpi awareness.
QApplication should parse and remove and args it recognizes before dolphin starts inspecting the args. This allows using e.g. -style <style> on the commandline.
lioncash
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
-style fusionand it will work)