Qt: Remove unused class GraphicsBoolEx #11776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In older versions of Dolphin GraphicsBoolEx was used to create a pair of radio buttons selecting one of Virtual XFB and Real XFB, but this was removed with the introduction of Hybrid XFB in 65cd085. In the meantime GraphicsRadioInt was introduced to allow for Graphics radio buttons with multiple options, so GraphicsBoolEx is now redundant.
Dentomologist
force-pushed
the
remove_graphicsboolex
branch
from
a04d207
to
4174f00
Compare
lioncash
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In older versions of Dolphin GraphicsBoolEx was used to create a pair of radio buttons selecting one of Virtual XFB and Real XFB, but this was removed with the introduction of Hybrid XFB in #5498.
In the meantime GraphicsRadioInt was introduced to allow for Graphics radio buttons with multiple options, and boolean options should use checkboxes, so GraphicsBoolEx is now redundant.