Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GBACore.cpp: Update to revised screen size/info API #11784

Merged
merged 1 commit into from Apr 23, 2023
Merged

GBACore.cpp: Update to revised screen size/info API #11784

merged 1 commit into from Apr 23, 2023
+8 −5

Conversation

Minty-Meeo
Copy link
Member

@Minty-Meeo Minty-Meeo force-pushed the mgba-screen-api branch 4 times, most recently from bc0acbd to cc6259b Compare April 23, 2023 08:30
@Minty-Meeo Minty-Meeo marked this pull request as ready for review April 23, 2023 08:30
@Minty-Meeo
Copy link
Member Author

Minty-Meeo commented Apr 23, 2023 •
edited

desiredVideoDimensions is replaced by either currentVideoSize or baseVideoSize. I went with currentVideoSize, as that function appears to be what became of the old desiredVideoDimensions API call. If we instead want baseVideoSize, let me know.

@AdmiralCurtiss
Copy link
Contributor

Sure, why not.

@AdmiralCurtiss AdmiralCurtiss merged commit 5df7c88 into dolphin-emu:master Apr 23, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@Minty-Meeo @AdmiralCurtiss