DolphinQt: cache icons instead of single pixmaps #11785
Merged
+95
−219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes dynamically changing dpi scaling.
Load resources from svg if possible.
Currently svg support is not in Qt build in Externals, and image files need to be added later.
you can find a build with my current accumulated qt changes and built against qt6.5 (with svg support) here: https://drive.google.com/file/d/1fMCdqPTmhYYc0yAvKY6kyBodMQ6J5VCv
this build also uses the default Qt6 dpi scale rounding mode of passthrough.
note: you should pass
-style fusionto this build if you want it to look pretty :')here are some svg resources i've collected: Resources.zip
these are mainly to see how the scaling looks. I don't care which actual images wind up being used.