Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of iconv code on OpenBSD #11793

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Apr 25, 2023

The ifdef'd path for OpenBSD was added with 2c355b8 with the addition of NetBSD support, but it does not build on OpenBSD.

Source/Core/Common/StringUtil.cpp:551:11: error: no matching function for call to 'libiconv'
          iconv(conv_desc, reinterpret_cast<const char**>(&src_buffer), &src_bytes, &dst_buffer,
          ^~~~~
/usr/local/include/iconv.h:80:15: note: expanded from macro 'iconv'
#define iconv libiconv
              ^~~~~~~~
/usr/local/include/iconv.h:82:15: note: candidate function not viable: no known conversion from 'const char **' to 'char **' for 2nd argument
extern size_t iconv (iconv_t cd,  char* * inbuf, size_t *inbytesleft, char* * outbuf, size_t *outbytesleft);
              ^
/usr/local/include/iconv.h:80:15: note: expanded from macro 'iconv'
#define iconv libiconv
              ^
1 error generated.

@lioncash lioncash merged commit d95a852 into dolphin-emu:master Apr 29, 2023
@brad0 brad0 deleted the openbsd_iconv_build_fix branch April 5, 2024 03:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants