Gecko/ARCode: Add sort by enabled state #11796
Merged
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Apr 26, 2023
sepalani
force-pushed
the
gecko-sort
branch
2 times, most recently
from
e3c504e
to
0a9b7cc
Compare
|
Maybe "Show Enabled Codes First" or something like that? "Sort By Enabled Codes" sounds a bit awkward IMO and doesn't really clarify what the option does. (Also, if you remove the past participle adjective then it becomes "Sort By Codes", which doesn't make sense.) |
| std::sort(m_ar_codes.begin(), m_ar_codes.end(), | ||
| [](const auto& a, const auto& b) { return a.enabled && a.enabled != b.enabled; }); |
There was a problem hiding this comment.
Maybe std::stable_sort so the order within the enabled/disabled set gets preserved?
lioncash
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR adds the ability to sort codes by enabled state which can be useful when you want to disable some codes but the code list is huge.
Ready to be reviewed & merged.