Revert "DolphinQt: use default dpi rounding mode (passthrough)" #11811
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cfe3683. On Windows systems with 125% DPI scaling, this was causing both icons and the OSD to be upscaled by 25% using nearest neighbor scaling, which looks really bad. shuffle2 has said that this will be improved later, but we should revert it for now for the sake of the upcoming beta build.
|
Is the "later" a "when Qt gets updated"? If so, would it make more sense to just adjust the Qt version cutoff to only enable it on Qt versions that handle this properly? |
|
@shuffle2, can you weigh in? |
|
seems easier to just revert then revert the revert. i'm not aware if there is actually intentional behavior difference in terms of the upscaling the pngs between qt versions, and in the future we'll eventually have svg anyway so |
|
@JosJuice, Will there be a "compact" mode, that cancels out UI scaling? Some people do not like UI becoming larger. Even with Qt update, SVG icons, etc, I think there should be an option to keep small icons. For example, with UI scaling grid view game covers take too much space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This reverts commit cfe3683 (PR #11788).
On Windows systems with 125% DPI scaling, this was causing both icons and the OSD to be upscaled by 25% using nearest neighbor scaling, which looks really bad. @shuffle2 has said that this will be improved later, but we should revert it for now for the sake of the upcoming beta build.