IOS: Further deglobalization and emulation/maintainance code splitting. #11825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
ios-split-es-fs
branch
from
f793236
to
094062c
Compare
leoetlino
approved these changes
May 15, 2023
Source/Core/Core/IOS/IOS.cpp
Outdated
| @@ -304,7 +304,7 @@ Kernel::Kernel(IOSC::ConsoleType console_type) : m_iosc(console_type) | |||
| ASSERT(m_fs); | |||
|
|
|||
| std::lock_guard lock(m_device_map_mutex); | |||
There was a problem hiding this comment.
I don't think we need to lock this mutex anymore
There was a problem hiding this comment.
Mhm, I suppose it doesn't make much sense to lock this in the constructor, yeah.
There was a problem hiding this comment.
In fact... is this mutex needed at all? It's only locked in the constructor, destructor, and a single function (GetDeviceByName()). (AddStaticDevices() is practically part of the constructor)
ESCore implements the core functionality that can also be used outside of emulation. ESDevice implements the IOS device and is only available during emulation.
FSCore implements the core functionality that can also be used outside of emulation. FSDevice implements the IOS device and is only available during emulation.
…modified in the constructor and destructor.
AdmiralCurtiss
force-pushed
the
ios-split-es-fs
branch
from
0c18430
to
28b82ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
@leoetlino You were interested in this back in #11787. I think this is a pretty good solution all things considered.