Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotkey to open Skylanders and Infinity Menus #11845

Merged

Conversation

jnaidu360
Copy link
Contributor

@jnaidu360 jnaidu360 commented May 26, 2023

Status

Ready to merge.

Skylanders and Infinity Menu Hotkeys

Creating two new hotkeys that open the Skylanders Portal and Infinity Base menus, so the game doesn't need to be exited each time. Added a tab in the hotkey settings menu for "USB Emulation" to set the hotkeys.

Default hotkeys:
Skylanders Portal of Power: Ctrl+P
Infinity Base: Ctrl+I

Note

This commit is not dependent on the Skylanders menu overhaul, can be merged with the current USB emulation menus.

Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise.

Source/Core/DolphinQt/Config/Mapping/HotkeyUSBEmu.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Config/Mapping/HotkeyUSBEmu.h Outdated Show resolved Hide resolved
@AdmiralCurtiss
Copy link
Contributor

Ah, you forgot to add the new files to the CMakeLists.

Adds two new hotkeys to open the menus for emulated USB devices- Skylanders Portal of Power and the Infinity Base. (Hotkeys only active when game is running).

Portal menu: Default is <Ctrl+P>.
Infinity base: Default is <Ctrl+I>
@jnaidu360
Copy link
Contributor Author

Ah, you forgot to add the new files to the CMakeLists.

My bad, just fixed. Also threw in a hotkey for the infinity base since it has the exact same implementation.

@jnaidu360 jnaidu360 changed the title Add Hotkey for Skylanders Portal Menu Add Hotkey to open Skylanders and Infinity Menus May 26, 2023
@jnaidu360 jnaidu360 changed the title Add Hotkey to open Skylanders and Infinity Menus Add hotkey to open Skylanders and Infinity Menus May 26, 2023
@jnaidu360
Copy link
Contributor Author

Should be ready to go.

@jnaidu360 jnaidu360 closed this May 26, 2023
@jnaidu360 jnaidu360 deleted the skylanders-portal-hotkey branch May 26, 2023 22:50
@jnaidu360 jnaidu360 restored the skylanders-portal-hotkey branch May 26, 2023 22:51
@jnaidu360 jnaidu360 reopened this May 26, 2023
@AdmiralCurtiss AdmiralCurtiss merged commit 4dc4b28 into dolphin-emu:master May 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants