Video: Fix lens_distortion post process shader not compiling

[Filoppi]

any() failed to build on my machine, but it doesn't seem to be necessary

[K0bin]

Which backend fails to compile that shader?

I'm pretty sure your fix is incorrect.

The GLSL spec says: (emphasis mine)

Any expression whose type evaluates to a Boolean can be used as the conditional expression bool-expression. Vector types are not accepted as the expression to if.

The .f suffix is also not used in GLSL as far as I know.

[iwubcode]

What's the error? If we're having issues with the conversion, we should report to the spirv-cross upstream project. They may want the SPIRV output too though...

[TellowKrinkle]

Just tested with the Metal backend, and it's glslang that's failing on the any, not spirv-cross

bad_ps_Metal_0.txt

I modified the shader a bit, which revealed the real reason why this is invalid:
bad_ps_Metal_0.txt

bvec2 oob = clamp(uv, 0.0, 1.0) != uv;
// ERROR: 0:201: '=' :  cannot convert from ' temp bool' to ' temp 2-component vector of bool'

Apparently comparison of a vec2 returns a bool, not a bvec2
There's an equal function for componentwise comparisons

Which means this fix is correct (though do remove the .f usage, IIRC glsl doesn't technically allow that, and decimals default to floats instead of doubles)

[iwubcode]

Very nice sleuthing @TellowKrinkle !