VideoCommon: add custom asset implementation and asset library #11871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this is fine I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AdmiralCurtiss - I know you've been reviewing a lot and I hope to make things easier for you when I can. Not sure why I didn't think of this originally but here's a more thinned down version of #11858 . Hopefully more mergeable :). Also, moved assets to 'Assets' folder. I've been sticking everything in GraphicsMods which is just bad practice... (CustomTextureData will move to 'Assets' too in a future review)
For those not following along, this adds a generic
CustomAssetinterface that can be used to load specific data for a particular object we consider an Asset (think of a texture). This also provides aCustomAssetLibrarywhich knows given anAssetID(a string) what asset to load. What that load looks like is dependent on the library implementation itself (no implementations are provided in this review but they will be in a future review).