VideoCommon: add multithreaded asset loader and define a texture asset #11877
+291
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase. |
| } | ||
|
|
||
| // Same deal if the custom texture isn't a multiple of the native size. | ||
| if (native_width != 0 && native_height != 0 && |
There was a problem hiding this comment.
Is a native_width or native_height of zero even valid? Maybe you want to catch that earlier and just return false for those cases.
There was a problem hiding this comment.
It does seem odd, this was just copied from here: https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/VideoCommon/HiresTextures.cpp#L329
iwubcode
force-pushed
the
asset_library_loader
branch
from
bd3aece
to
c93940c
Compare
|
@AdmiralCurtiss - thanks again for looking these over! All good now assuming that comment isn't a blocker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.