VideoCommon: prevent potential data issue when reloading Asset data #11880
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat could happen due to the asset loading thread reloading data while another thread is working with it
|
Yes, you're right, this can definitely happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I was looking back over the asset logic and wondered if there might be a problem.
If in the middle of an asset being reloaded, imagine that a callee has called
GetData(). This would give them a pointer to that data. If they are still operating on that data when the asset is reloaded, then the data would be modified on the asset reload thread. This could be potentially dangreous at worst or lead to incorrect data at best. To avoid this, I return ashared_ptrensuring that the callee will have access to the original data for the lifetime of the smart ptr.