Android: Convert "ui" package to Kotlin #11886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Jun 5, 2023
| constructor(context: Context?) : this(context, null) | ||
|
|
||
| constructor(context: Context?, attrs: AttributeSet?) : this(context, attrs, 0) |
There was a problem hiding this comment.
You could use default values for the parameters instead of defining auxiliary constructors.
There was a problem hiding this comment.
I can remove the first constructor I have there just fine but even with my default parameters defined, the app crashes if you don't define the second constructor.
There was a problem hiding this comment.
Oh wait, I realized I could use the @JvmOverloads annotation to do exactly what you were thinking.
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainActivity.kt
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/platform/PlatformGamesFragment.kt
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/platform/PlatformGamesView.kt
Show resolved
Hide resolved
t895
force-pushed
the
kotlin-ui
branch
2 times, most recently
from
e9b0ecd
to
4ab1909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.