DolphinQt/InfinityBaseWindow: Minor changes #11907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents potential inclusion issues.
tr() already returns a QString, so we don't need to construct a QString around it, and FindFigure() already returns a std::string.
The parameters to this match the requirements of the toggled() function exactly, so we can pass the function directly into the connect call.
JosJuice
approved these changes
Jun 8, 2023
Restricts the headers to the cpp file where they're needed and prevents the headers from "leaking" into other translation units.
|
Oh, good catch. Amended the commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially intended to only add the missing header guard, I noticed a few other changes that could be made and decided to include those as well, since they don't really deserve their own individual PRs.