VideoBackends:Metal: Enable shouldMaximizeConcurrentCompilation when available #11911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OatmealDome - are you comfortable reviewing or at least testing this? |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
OatmealDome
approved these changes
Jun 10, 2023
|
This PR makes Dolphin crash when starting emulation, with the following error:
From this MoltenVK snippet, it seems that even on macOS > 13.3 the feature needs to be dynamically tested (which seems fine in this context). I opened an issue to track this: https://bugs.dolphin-emu.org/issues/13404 |
|
MoltenVK always prefers respondsToSelector checks over version-based checks, and has the availability warnings disabled, if we used it as a reference we'd dynamically test everything. Are you using OCLP? Can you get your actual CPU model with |
And yes, that's using OCLP. I think Haswell GPUs are not natively supported on macOS >= 12, so the actual cause may be that the legacy driver bundled in OCLP does not implement the latest 13.3 improvements. Continuing the discussion in #12311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS 13.3 finally lets us use all our cores when compiling shaders, turn that on
Improves launch time with Compile Shaders Before Starting + Ubershaders
For anyone who wants to test, clear your Metal shader cache with
rm -r $TMPDIR/../C/org.dolphin-emu.dolphin/com.apple.metal