Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved DPI change handling #11918

Merged
merged 2 commits into from Jun 17, 2023
Merged

Improved DPI change handling #11918

merged 2 commits into from Jun 17, 2023

Conversation

TellowKrinkle
Copy link
Contributor

  • Windows now get notified when they move between monitors with different DPIs
    • MoltenVK no longer gets squished into a tiny corner of the window or expanded to 2x the window size when moving
  • DPI changes are now reflected in imgui, and imgui no longer explodes if you set its dpi more than once
    • Metal is currently the only renderer that fully notices DPI changes and tells imgui about it. I'll deal with the others some other time.

iwubcode
iwubcode approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested. Code LGTM!

@AdmiralCurtiss AdmiralCurtiss merged commit 1aef85a into dolphin-emu:master Jun 17, 2023
14 checks passed
@TellowKrinkle TellowKrinkle deleted the DPIScale branch June 17, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MayImilae MayImilae MayImilae left review comments

@iwubcode iwubcode iwubcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@TellowKrinkle @MayImilae @iwubcode @AdmiralCurtiss