Android: Gradle updates #11929
Merged
Android: Gradle updates #11929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally updates the serialization plugin to match
|
Is this ready for merge? I'm not sure if the testing you're mentioning needing to do is before merging this PR or before removing the clean command. |
|
I just ran a test with the repo provided on the original google issue and it still breaks builds sadly. For whatever reason I've had good luck with it working on yuzu for android. Regardless, this is ready to merge and we could still run tests later to see if we could remove that workaround step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to do further testing to make sure that I won't break the build bot (I would only break it if I removed the clean command on our android bot) but this should fix the incremental build issue as well