Use getCacheDir if getExternalCacheDir returns null. #11935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitanmarcel
changed the title
nitanmarcel
force-pushed
the
patch-1
branch
2 times, most recently
from
9eaf685
to
3b6f6fd
Compare
JosJuice
reviewed
Jun 12, 2023
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/DirectoryInitialization.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/DirectoryInitialization.java
Outdated
Show resolved
Hide resolved
nitanmarcel
force-pushed
the
patch-1
branch
2 times, most recently
from
1c09e94
to
5479714
Compare
|
Everything should be done I guess. Sorry for the force push but didn't wanted to have a bunch of commits for all the small fixes ^^ |
A force push is what we prefer in situations like these. |
|
LGTM if you fix the lint error. |
I hope it was the intend. Should be fixed now once the built starts again. I hope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a weird problem encountered in certain custom ROMs where the getExternalCacheDir method occasionally returns a null value.