x64EmitterTest: add J/J_CC/CALL unit tests #11959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For near vs short specifically, I think it might make sense to compare the raw bytes, seeing as the disassembly doesn't explicitly note which jumps are near and which jumps are short. The way the test is implemented right now, it could theoretically pass if both near vs short and the offset are incorrect in a way that happens to match up. |
Check bytes directly to avoid ambiguity in the disassembly between short and near jumps, which could hypothetically cause the test to pass when it shouldn't.
Dentomologist
force-pushed
the
add_x64emitter_unittests
branch
from
7977b0f
to
4ccac53
Compare
|
Near and short jumps now check the raw bytes, and I added a commit to do that in JMP as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some missing x64Emitter unit tests.