Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoBackends: fix d3d12 error when validation layers enabled #11963

Merged
merged 1 commit into from Jun 18, 2023

Conversation

iwubcode
Copy link
Contributor

@iwubcode iwubcode commented Jun 17, 2023

This was an oversight caused by my multi-output texture change. This code was pulled from an older PR, I can't say why I did it this way. Maybe multiple logic ops RTs are invalid or maybe it was that it would negatively impact users due to the integer format required? (am i remembering right?) Anyway, this fixes a validation error that causes d3d12 to crash with the error:

ERROR: ID3D12Device::CreateGraphicsPipelineState: The render target format at slot 0 is format (R8G8B8A8_UNORM). This format does not support logic ops. The Pixel Shader output signature indicates this output could be written, and the Blend State indicates logic op is enabled for this slot.

When I get to using multiple-output textures, I will revisit

@iwubcode iwubcode changed the title VideoBackends: fix d3d12 crash on game start VideoBackends: fix d3d12 crash with validation errors on Jun 17, 2023
@iwubcode iwubcode changed the title VideoBackends: fix d3d12 crash with validation errors on VideoBackends: fix d3d12 crash with validation layers enabled Jun 17, 2023
@iwubcode iwubcode changed the title VideoBackends: fix d3d12 crash with validation layers enabled VideoBackends: fix d3d12 error when validation layers enabled Jun 17, 2023
@AdmiralCurtiss AdmiralCurtiss merged commit 9e06b69 into dolphin-emu:master Jun 18, 2023
14 checks passed
@iwubcode iwubcode deleted the d3d12_fix branch June 19, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants