xEmitter: Convert PrefetchLevel to enum class #11966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source/Core/Common/x64Emitter.h
Outdated
| @@ -481,12 +481,12 @@ class XEmitter | |||
| void BSR(int bits, X64Reg dest, const OpArg& src); // Top bit to bottom bit | |||
|
|
|||
| // Cache control | |||
| enum PrefetchLevel | |||
| enum class PrefetchLevel | |||
There was a problem hiding this comment.
enum class PrefetchLevel : u8
Are those guaranteed to be identical to the values used in the actual binary instruction? |
Dentomologist
force-pushed
the
convert_xemitter_prefetchlevel_to_enum_class
branch
from
fb31977
to
04fcf68
Compare
I would have thought so (and they are for me) but can't find a guarantee about that; I've replaced them with literals. |
AdmiralCurtiss
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.
I also want to explicitly assign the enum values (_MM_HINT_NTA, etc.); I can throw that in this PR or make a new one if that's worth the effort.