Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jit64: Fix trampolines after #11834. #11969

Merged
merged 1 commit into from Jun 17, 2023
Merged

Jit64: Fix trampolines after #11834. #11969

merged 1 commit into from Jun 17, 2023

Conversation

AdmiralCurtiss
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss commented Jun 17, 2023 •
edited

Fixes RS2 again, probably among lots of other things. See also #11967.

Pokechu22
Pokechu22 approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@Pokechu22 Pokechu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this fixes RS2.

Dentomologist
Dentomologist approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@Dentomologist Dentomologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a sudden urge to replace every part of the codebase that does if(pointer) with if(pointer != nullptr).

@AdmiralCurtiss AdmiralCurtiss merged commit 4449887 into dolphin-emu:master Jun 17, 2023
14 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the thats-no-bool branch June 17, 2023 23:38
@JosJuice JosJuice mentioned this pull request Jun 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pokechu22 Pokechu22 Pokechu22 approved these changes

@Dentomologist Dentomologist Dentomologist approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@AdmiralCurtiss @Pokechu22 @Dentomologist